Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Renamed baseline.rs and dump.rs files #348

Merged
merged 7 commits into from
Feb 5, 2023
Merged

Renamed baseline.rs and dump.rs files #348

merged 7 commits into from
Feb 5, 2023

Conversation

tonowak
Copy link
Collaborator

@tonowak tonowak commented Feb 4, 2023

This PR is stacked on #347.
It renames:

  • baseline.rs -> rustdoc_gen.rs
  • dump.rs -> rustdoc_cmd.rs (and RustDocCommand -> RustdocCommand)

@tonowak tonowak requested a review from obi1kenobi February 4, 2023 20:17
@tonowak tonowak mentioned this pull request Feb 4, 2023
Merged
obi1kenobi
obi1kenobi reviewed Feb 5, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine. I'll add some trivial changes and merge it so we can move forward faster.

src/rustdoc_gen.rs Outdated Show resolved Hide resolved
src/rustdoc_gen.rs Outdated Show resolved Hide resolved
src/rustdoc_gen.rs Outdated Show resolved Hide resolved
src/rustdoc_gen.rs Show resolved Hide resolved
src/rustdoc_gen.rs Show resolved Hide resolved
@obi1kenobi obi1kenobi enabled auto-merge (squash) February 5, 2023 03:15
obi1kenobi
obi1kenobi reviewed Feb 5, 2023
View reviewed changes
src/rustdoc_gen.rs Outdated Show resolved Hide resolved
@obi1kenobi obi1kenobi mentioned this pull request Feb 5, 2023
Merged
@obi1kenobi obi1kenobi disabled auto-merge February 5, 2023 03:22
@obi1kenobi obi1kenobi enabled auto-merge (squash) February 5, 2023 03:47
@obi1kenobi obi1kenobi merged commit 4920a4e into obi1kenobi:main Feb 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonowak @obi1kenobi