Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add --release-type flag #361

Merged
merged 7 commits into from
Feb 11, 2023
Merged

Add --release-type flag #361

merged 7 commits into from
Feb 11, 2023

Conversation

Finomnis
Copy link
Contributor

@Finomnis Finomnis commented Feb 9, 2023

Closes #359

obi1kenobi
obi1kenobi reviewed Feb 9, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple of tiny suggestions.

@epage what do you think? Are you okay with --assume-semver as the flag name?

src/query.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@Finomnis @obi1kenobi
Update src/main.rs
f560658 
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
@Finomnis
Copy link
Contributor Author

Finomnis commented Feb 9, 2023 •
edited
Loading

Good chance that this won't get merged as-is, in favor of a --lint-level flag that doesn't enforce the version difference, but filters the actual checks.

@Finomnis
Copy link
Contributor Author

Finomnis commented Feb 9, 2023

Closed in favor of #362.

@Finomnis Finomnis closed this Feb 9, 2023
@Finomnis Finomnis deleted the assume_semver branch February 9, 2023 23:59
@obi1kenobi
Copy link
Owner

obi1kenobi commented Feb 11, 2023 •
edited
Loading

@Finomnis apparently I don't have the power to reopen this, since the underlying branch has been deleted. Whenever you get a sec, if you can reopen and change the variable/flag names to release_type instead of assume_semver, I will happily merge it and cut a new release shortly thereafter.

Thanks for bearing with us! Most PRs aren't nearly so involved — this one was a 99.5%+ percentile outlier 😅

@Finomnis Finomnis restored the assume_semver branch February 11, 2023 07:56
This was referenced Feb 11, 2023
Closed
Closed
@Finomnis Finomnis changed the title Add --assume-semver flag Add --release-type flag Feb 11, 2023
@Finomnis Finomnis reopened this Feb 11, 2023
@Finomnis Finomnis mentioned this pull request Feb 11, 2023
Closed
obi1kenobi
obi1kenobi approved these changes Feb 11, 2023
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@obi1kenobi obi1kenobi enabled auto-merge (squash) February 11, 2023 13:19
auto-merge was automatically disabled February 11, 2023 13:20

Head branch was pushed to by a user without write access

@obi1kenobi obi1kenobi enabled auto-merge (squash) February 11, 2023 13:22
@obi1kenobi obi1kenobi merged commit 9b4a735 into obi1kenobi:main Feb 11, 2023
@Finomnis Finomnis deleted the assume_semver branch February 11, 2023 13:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@epage epage epage left review comments

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a command-line flag to override the major/minor/patch release detection logic
3 participants
@Finomnis @obi1kenobi @epage