Replace GNU-specific commands with more portable alternatives #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace grep -z (GNU-only) with an equivalent awk invocation. - Replace sed -i (option behaves differently on Mac vs GNU) with tmpfile - Replace sed -z (GNU-only). New lints are prepended instead of appended
The contributor-facing scripts (make_new_lint, make_test_crate, regenerate_test_rustdocs) no longer have any dependencies on GNU-only command line tools, so those have been removed from the guide.
obi1kenobi
approved these changes
Mar 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#680 enhancements
The replacement commands are functionally equivalent with one exception: new lints are now added to the beginning of the
add_lint!()macro instead of the end. (There is a way to append but would require a slightly more complexawkcommand). More details in the commit messages.