Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Raise compile-time and runtime MSRV to Rust 1.74. #686

Merged
merged 2 commits into from
Mar 8, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Raise compile-time and runtime MSRV to Rust 1.74.
cargo-semver-checks now requires Rust 1.74+ in order to compile, and only supports rustdoc generated by Rust 1.74+ meaning the installed Rust at runtime must be 1.74+ as well.

This is largely motivated by many of our dependencies raising their MSRVs to 1.74, which made it tedious for us to support older Rust versions.
obi1kenobi committed Mar 8, 2024
commit 28227bc853dbcd9a8fa0105b912849392c391415
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -154,7 +154,7 @@ jobs:
# IMPORTANT: When updating the versions here, make sure you also update
# the `fails-on-too-old-rustc` job and its error message to
# to account for the raised minimum required version.
toolchain: ["1.71", "1.72", "1.73", "1.74", "1.75", "stable", "beta"]
toolchain: ["1.74", "1.75", "stable", "beta"]
experimental: [false]
include:
- toolchain: "nightly"
@@ -1684,7 +1684,7 @@ jobs:
id: toolchain
uses: actions-rust-lang/setup-rust-toolchain@v1
with:
toolchain: "1.70"
toolchain: "1.73"
rustflags: ""
cache: false

@@ -1727,7 +1727,7 @@ jobs:
- name: Check output
run: |
cd semver
EXPECTED="$(echo -e "error: rustc version is not high enough: >=1.71.0 needed, got 1.70.0")"
EXPECTED="$(echo -e "error: rustc version is not high enough: >=1.74.0 needed, got 1.73.0")"
RESULT="$(cat output | grep 'error: rustc version')"
diff <(echo "$RESULT") <(echo "$EXPECTED")
20 changes: 0 additions & 20 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
@@ -9,13 +9,13 @@ repository = "https://github.com/obi1kenobi/cargo-semver-checks"
readme = "./README.md"
keywords = ["semver", "check", "crate", "cargo"]
categories = ["command-line-utilities", "development-tools::cargo-plugins"]
rust-version = "1.70"
rust-version = "1.74"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
trustfall = "0.7.1"
trustfall_rustdoc = { version = "0.14.1", default-features = false, features = ["v26", "v27", "v28"] }
trustfall_rustdoc = { version = "0.14.1", default-features = false, features = ["v27", "v28"] }
clap = { version = "4.0.0", features = ["derive", "cargo"] }
serde_json = "1.0.82"
anyhow = "1.0.58"
2 changes: 1 addition & 1 deletion src/config.rs
Original file line number Diff line number Diff line change
@@ -52,7 +52,7 @@ impl GlobalConfig {
}
})),
handlebars: make_handlebars_registry(),
minimum_rustc_version: semver::Version::new(1, 71, 0),
minimum_rustc_version: semver::Version::new(1, 74, 0),
}
}