Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add lint for union field missing case #729

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

me-diru
Copy link
Contributor

@me-diru me-diru commented Mar 30, 2024

Covers

pub union's pub field removed / renamed (no longer present under its previous name, by whatever cause)

case in Issue #633

Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor polish items.

If you agree with all my suggestions, I'm happy to apply them and merge this right away!

src/lints/union_field_missing.ron Outdated Show resolved Hide resolved
src/lints/union_field_missing.ron Outdated Show resolved Hide resolved
src/lints/union_field_missing.ron Outdated Show resolved Hide resolved
src/lints/union_field_missing.ron Outdated Show resolved Hide resolved
@me-diru
Copy link
Contributor Author

me-diru commented Mar 31, 2024

LGTM! :D thanks for the review

@obi1kenobi
Copy link
Owner

Awesome, thanks for putting this together! If you feel like writing more lints, I'd love to merge those too 😁

@obi1kenobi obi1kenobi enabled auto-merge (squash) March 31, 2024 07:01
@obi1kenobi
Copy link
Owner

Queued up for merge as soon as CI passes.

@obi1kenobi obi1kenobi merged commit dd63a1c into obi1kenobi:main Mar 31, 2024
32 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants