Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add more detailed message when no library targets found. #741

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

jw013
Copy link
Contributor

@jw013 jw013 commented Apr 13, 2024

Resolves #723

@obi1kenobi
Copy link
Owner

Looks good! Might have to update a test or two though.

@jw013
Copy link
Contributor Author

jw013 commented Apr 13, 2024

I updated the tests that check the output. I'm a little stumped about the remaining CI failures - I see mentions of rustdoc v29, though, so I assume that's unrelated?

@obi1kenobi
Copy link
Owner

Huh, a new rustdoc format version must have been released without me noticing... Curious 🤔

I'll fix that, thanks for bringing my attention to it!

@obi1kenobi
Copy link
Owner

Fixing the nightly build is blocked pending a new version of an upstream crate being published. But that's why it's a non-required step in our CI -- we can merge without it.

I've fixed the other step that was problematic, so this can merge.

Thanks again!

@obi1kenobi obi1kenobi enabled auto-merge (squash) April 14, 2024 15:44
@obi1kenobi obi1kenobi merged commit 2f235c7 into obi1kenobi:main Apr 14, 2024
30 of 31 checks passed
@jw013 jw013 deleted the no_targets branch April 14, 2024 19:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when no library targets are found
2 participants