Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

annotate unreachable!() statements #808

Merged
merged 1 commit into from
Jul 6, 2024
Merged

annotate unreachable!() statements #808

merged 1 commit into from
Jul 6, 2024

Conversation

suaviloquence
Copy link
Contributor

from #805

@suaviloquence
Copy link
Contributor Author

this commit broke nightly, btw: rust-lang/rust@7e8aac5

obi1kenobi
obi1kenobi approved these changes Jul 6, 2024
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Thanks for the heads-up on the new rustdoc JSON format version. I think it's likely there's going to be another iteration on the format very soon, so I'll hold off for a few days to see if that gets merged and released quickly enough or not.

@obi1kenobi obi1kenobi merged commit 137790a into obi1kenobi:main Jul 6, 2024
34 of 35 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suaviloquence @obi1kenobi