Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

make specifying workspace = false a hard error #813

Merged
merged 2 commits into from
Jul 12, 2024
Merged

make specifying workspace = false a hard error #813

merged 2 commits into from
Jul 12, 2024

Conversation

suaviloquence
Copy link
Contributor

For compatibility with cargo. This PR keeps the original API but validates that the user hasn't specified workspace = false while deserializing.

obi1kenobi
obi1kenobi reviewed Jul 12, 2024
View reviewed changes
src/manifest.rs Outdated Show resolved Hide resolved
obi1kenobi
obi1kenobi approved these changes Jul 12, 2024
View reviewed changes
Copy link
Owner

@obi1kenobi obi1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Merging with a tweak to use single-spaced style in user-facing messages.

@obi1kenobi obi1kenobi enabled auto-merge (squash) July 12, 2024 21:09
@obi1kenobi obi1kenobi merged commit 363754a into obi1kenobi:main Jul 12, 2024
33 of 34 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@obi1kenobi obi1kenobi obi1kenobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suaviloquence @obi1kenobi