Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add explicit features for gix backend #824

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

ggwpez
Copy link
Contributor

@ggwpez ggwpez commented Jul 22, 2024

Update tame-index and integrate the latest change: EmbarkStudios/tame-index#66

This merge request is adding two features to allow downstream developers to select which gix backend to use. Since Rust unifies the feature of a crate when building it, and gix has two mutually exclusive features, the only way here seems to propagate this oddity and expose it in the features of this crate as well.

More concretely, this conflicts otherwise in our crate where we also pull in cargo which then always enables the curl backend.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Cargo.toml Show resolved Hide resolved
@obi1kenobi obi1kenobi enabled auto-merge (squash) July 24, 2024 17:38
@obi1kenobi obi1kenobi merged commit 1e0c823 into obi1kenobi:main Jul 24, 2024
33 checks passed
@obi1kenobi
Copy link
Owner

This functionality is now available in v0.33.0!

@Lorak-mmk
Copy link

I think it is after this PR not possible to do cargo install cargo-semver-checks --no-default-features - it fails to compile. Is that expected? I can't find anything about this in release notes

@obi1kenobi
Copy link
Owner

Oops! 😅

In retrospect, yes, that's a breaking change. I should have called it out in the release notes!

I didn't realize it was breaking and @ggwpez might not have noticed it either.

The irony of a breaking change linter having an unexpected breaking change is not lost on me 😅 This is why I want cargo-semver-checks lints that can check manifests: https://rust-lang.github.io/rust-project-goals/2024h2/cargo-semver-checks.html

@obi1kenobi
Copy link
Owner

I have updated the release notes to mention this, and offer the updated command cargo install cargo-semver-checks --no-default-features --features gix-reqwest that reproduces the previous behavior.

Thanks for reporting this, and I'm sorry I broke your workflow!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants