fix: regenerate script toplevel resolution #873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻,
I wanted to check on #870. (EDIT: sorry for linking the issue without a real connection)
When loading the
regenerate_test_rustdocs.sh
script, it would just outputGenerating rustdoc with: cargo 1.80.1 (376290515 2024-07-16)
and then exit promptly. Upon closer examination, theTOPLEVEL
variable would end up having two values, thus silently crashing the rest of the program.Though my bash knowledge is limited, I think this is what is happening:
Wrapping the second part of the logical
OR
resolves the issue.It seems that #856, introduced this and was recently committed.