feat: add lint struct_marked_non_exhaustive_changed_type
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
changed the title
struct_marked_non_exhaustive_changed_typestruct_marked_non_exhaustive_changed_type
2 tasks
CommanderStorm
force-pushed
the
struct_marked_non_exhaustive_changed_type
branch
from
51816ae to
286659f
Compare
CommanderStorm
force-pushed
the
struct_marked_non_exhaustive_changed_type
branch
from
e2832af to
104b00c
Compare
obi1kenobi
reviewed
Oct 7, 2024
CommanderStorm
commented
Oct 7, 2024
test_outputs/query_execution/struct_marked_non_exhaustive_changed_type.snap
Outdated
Show resolved
Hide resolved
test_outputs/witnesses/struct_marked_non_exhaustive_changed_type.snap
Outdated
Show resolved
Hide resolved
Co-authored-by: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com>
obi1kenobi
reviewed
Oct 7, 2024
|
I think this still needs a snapshot file update to pass CI. I'm guessing you did a manual find-and-replace on the lint name in the snapshots, but that upset the ordering? If you have a second to update the snapshot, I can merge and release this in the upcoming version this week. |
Oops, missed those files / forgot to change the testcases during the renaming |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implemnents the second part of #954
Resolves #954
TODO:
struct_with_no_pub_fields_changed#962, to remove the merge conflict once that is merged ^^=> will need to rebase before this is reviewable