Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add fields to Variant interface #25

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

staniewzki
Copy link
Contributor

This PR adds fields edge to Variant interface, as described in obi1kenobi/cargo-semver-checks#253.

Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
@obi1kenobi
Copy link
Owner

obi1kenobi commented Jan 6, 2023

This is great. Would you mind making the matching PRs for the other rustdoc versions, including the new v24 one?

git cherry-pick of the commit onto the other branches should do the trick. It's possible that v24 needs a touch more code, since the representation of enums is slightly changed.

After we have merged all the PRs, we can release the new versions.

@obi1kenobi obi1kenobi merged commit 86921a6 into obi1kenobi:rustdoc-v22 Jan 6, 2023
staniewzki added a commit to staniewzki/trustfall-rustdoc-adapter that referenced this pull request Jan 6, 2023
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>

Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
@staniewzki
Copy link
Contributor Author

Done!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants