Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add NotificationClient as feature #212

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Add NotificationClient as feature #212

merged 3 commits into from
Oct 30, 2023

Conversation

tophtucker
Copy link
Contributor

@tophtucker tophtucker commented Oct 13, 2023 •
edited
Loading

+2 lines of logic, +3 lines of test inputs, +315 lines of test outputs. 😅

@tophtucker tophtucker requested a review from mbostock October 24, 2023 03:52
mbostock
mbostock reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tophtucker tophtucker merged commit 82211b8 into main Oct 30, 2023
@tophtucker tophtucker deleted the toph/notification-client branch October 30, 2023 20:09
@tophtucker tophtucker mentioned this pull request Nov 4, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mbostock mbostock mbostock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tophtucker @mbostock