feat: enable forwarder daemonset by default #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obs-gh-alexlew
force-pushed
the
alew/enable-forwarder-by-default
branch
4 times, most recently
from
b01892a to
832a679
Compare
| @@ -13,6 +13,7 @@ resource "helm_release" "observe-agent" { | |||
| { | |||
| observe_url = var.observe_url, | |||
| observe_token = var.observe_token, | |||
| trace_token = var.observe_token, | |||
There was a problem hiding this comment.
If trace token is now becoming part of default helm deployment, it needs to be defined in this file
https://github.com/observeinc/helm-charts/blob/main/integration/modules/deploy_helm/variables.tf
Not sure why its specifically showing the "observe" namespace error but my guess is that it has to do something with this variable (or default) not being defined. Terraform plan is probably borked and the tftests don't really do plan/apply verbose like regular terraform
obs-gh-alexlew
force-pushed
the
alew/enable-forwarder-by-default
branch
5 times, most recently
from
4804f9c to
f4ae563
Compare
| @@ -2,7 +2,7 @@ | |||
| This example shows how to inject additional OTEL Config to the Observe Agent(s) that are running in the deployments and daemonsets. The additional config can add new instances of components such as receivers, processors, and exporters as well as to define new pipelines using those components. In addition, new pipelines can also use existing components from the default config. | |||
|
|
|||
| ## Values.yaml | |||
| In the helm chart, there are 3 deployments of Observe Agent and 1 daemonset. Each of these can have additional config injected. Each service has a corresponding field `agent.config.<service>` where the additional config can be added. The value of this field is a valid OTEL configuration in yaml format. The example values.yaml provided shows where custom OTEL config can be added for each of the four services. | |||
| In the helm chart, there are 3 deployments of Observe Agent and 2 daemonset. Each of these can have additional config injected. Each service has a corresponding field `agent.config.<service>` where the additional config can be added. The value of this field is a valid OTEL configuration in yaml format. The example values.yaml provided shows where custom OTEL config can be added for each of the four services. | |||
There was a problem hiding this comment.
Suggested change
| In the helm chart, there are 3 deployments of Observe Agent and 2 daemonset. Each of these can have additional config injected. Each service has a corresponding field `agent.config.<service>` where the additional config can be added. The value of this field is a valid OTEL configuration in yaml format. The example values.yaml provided shows where custom OTEL config can be added for each of the four services. | |
| In the helm chart, there are 3 deployments of Observe Agent and 2 daemonsets. Each of these can have additional config injected. Each service has a corresponding field `agent.config.<service>` where the additional config can be added. The value of this field is a valid OTEL configuration in yaml format. The example values.yaml provided shows where custom OTEL config can be added for each of the four services. |
integration/scripts/test_basic.py
Outdated
| @@ -11,7 +11,7 @@ | |||
| "node_taint.yaml") | |||
| def test_helm_correctness(apps_client, helm_config): | |||
| """ | |||
| Test to verify there are 3 deployments and 1 daemonset in the cluster. | |||
| Test to verify there are 3 deployments and 2 daemonset in the cluster. | |||
There was a problem hiding this comment.
Suggested change
| Test to verify there are 3 deployments and 2 daemonset in the cluster. | |
| Test to verify there are 3 deployments and 2 daemonsets in the cluster. |
integration/scripts/test_basic.py
Outdated
| @@ -21,7 +21,7 @@ def test_helm_correctness(apps_client, helm_config): | |||
| # Retrieve the daemonsets in the specified namespace | |||
| print(f"Checking Daemonsets in namespace: {helm_config['namespace']}") | |||
| daemonsets = apps_client.list_namespaced_daemon_set(namespace=helm_config['namespace']).items | |||
| assert len(daemonsets) == 1, f"Expected 1 daemonset in namespace '{helm_config['namespace']}', but found {len(daemonsets)}" | |||
| assert len(daemonsets) == 2, f"Expected 2 daemonset in namespace '{helm_config['namespace']}', but found {len(daemonsets)}" | |||
There was a problem hiding this comment.
Suggested change
| assert len(daemonsets) == 2, f"Expected 2 daemonset in namespace '{helm_config['namespace']}', but found {len(daemonsets)}" | |
| assert len(daemonsets) == 2, f"Expected 2 daemonsets in namespace '{helm_config['namespace']}', but found {len(daemonsets)}" |
obs-gh-alexlew
force-pushed
the
alew/enable-forwarder-by-default
branch
from
f4ae563 to
cb202a9
Compare
obs-gh-alexlew
force-pushed
the
alew/enable-forwarder-by-default
branch
from
cb202a9 to
1e00dc5
Compare
obs-gh-mattcotter
approved these changes
Feb 5, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.