Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add plugin: Publish url #2634

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Conversation

HananoshikaYomaru
Copy link
Contributor

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/HananoshikaYomaru/obsidian-publish-url

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Nov 3, 2023

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ] in JSON at position 298664


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Update community-plugins.json Add plugin: Publish url Nov 3, 2023
@HananoshikaYomaru
Copy link
Contributor Author

In the LICENSE, Yeung Man Lung Ken is my name on passport. Don't ask me to change it.

@joethei
Copy link
Collaborator

joethei commented Nov 10, 2023

"Template Number"
Use sentence case in UI
Also, without reading the code it is not obvious what this setting is for, you should add a description and change the name of this setting.

obsidian-ex.d.ts
Please credit the source of this code.

@joethei joethei self-assigned this Nov 10, 2023
@joethei joethei added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Nov 10, 2023
@HananoshikaYomaru
Copy link
Contributor Author

@joethei this is done, please help review again

@joethei joethei added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Nov 21, 2023
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin name mismatch, the name in this PR (Publish URL) is not the same as the one in your repo (Publish url). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@liamcain liamcain merged commit 4629009 into obsidianmd:master Nov 30, 2023
1 check failed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants