Remove errors and warning for local packages without a library component #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@3noch Anything blocking merging this? |
Ericson2314
reviewed
Nov 5, 2020
| @@ -386,9 +387,6 @@ parsePackagesOrFail dirs' = do | |||
| "No valid, buildable packages found" <> (if null dirs then "" else " in " <> intercalate ", " dirs) | |||
| Just xs -> pure xs | |||
|
|
|||
| unless (null pkgDirErrs) $ | |||
| putLog Warning $ T.pack $ "Failed to find buildable packages in " <> intercalate ", " pkgDirErrs | |||
There was a problem hiding this comment.
It's related in that you also get this warning for a package with no library component, in addition to the error above. I don't think either of them should be considered out of the ordinary.
There was a problem hiding this comment.
Ah and there is no more Either.
Ericson2314
approved these changes
Nov 6, 2020
|
Thanks, Kenny |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ob shelland derivative commands will print errors like this if you have a local package without a library component:I don't see any reason why this should be considered an erroneous case.
This removes the
Failed to find buildable packages in ...warning, but I don't believe it's necessary since any actual errors or warnings will still be reported byparseCabalPackage.I have:
developbranchhlint .(lint found code you did not write can be left alone)$(nix-build -A selftest --no-out-link)nix-build release.nix -A build.x86_64-linux --no-out-link(orx86_64-darwinon macOS)