Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add some haddocks to the deploy module #913

Merged
merged 6 commits into from
May 17, 2022
Merged

Add some haddocks to the deploy module #913

merged 6 commits into from
May 17, 2022

Conversation

madeline-os
Copy link
Collaborator

@madeline-os madeline-os commented May 5, 2022 •
edited
Loading

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@madeline-os madeline-os self-assigned this May 10, 2022
ryantrinkle
ryantrinkle approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@ryantrinkle ryantrinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@madeline-os madeline-os merged commit 7c66516 into develop May 17, 2022
@madeline-os madeline-os mentioned this pull request May 20, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ryantrinkle ryantrinkle ryantrinkle approved these changes

@cgibbard cgibbard Awaiting requested review from cgibbard

@danbornside danbornside Awaiting requested review from danbornside

Assignees

@madeline-os madeline-os

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madeline-os @ryantrinkle