Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix knownHost using staticWithNix #931

Merged
merged 7 commits into from
Jun 14, 2022
Merged

Fix knownHost using staticWithNix #931

merged 7 commits into from
Jun 14, 2022

Conversation

romefeller
Copy link
Contributor

I have:

  • Based work on latest develop branch
  • Followed the contribution guide
  • Looked for lint in my changes with hlint . (lint found code you did not write can be left alone)
  • Run the test suite: $(nix-build -A selftest --no-out-link)
  • Updated the changelog
  • (Optional) Run CI tests locally: nix-build release.nix -A build.x86_64-linux --no-out-link (or x86_64-darwin on macOS)

@romefeller romefeller changed the base branch from master to develop May 23, 2022 23:27
@romefeller romefeller requested a review from madeline-os May 24, 2022 03:06
Copy link
Collaborator

@madeline-os madeline-os left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think we need a test for this. It should cover the original feature, and ensures that it operates as expected. This might be a little tricky. If it's not clear how to proceed, let's talk about it.

@madeline-os
Copy link
Collaborator

@romefeller I don't think we have deploy tests yet so nevermind. i would like for you to verify that it works on an EC2 deploy before we merge, tho.

@romefeller
Copy link
Contributor Author

@romefeller I don't think we have deploy tests yet so nevermind. i would like for you to verify that it works on an EC2 deploy before we merge, tho.

@madeline-os ok.

@madeline-os madeline-os merged commit 64a417c into develop Jun 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants