Skip to content

Commit

Permalink
linux-pipewire: Fix 10- and 16-bit captures
Browse files Browse the repository at this point in the history
  • Loading branch information
PancakeTAS committed Feb 16, 2025
1 parent 64cb68a commit 7b21524
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 8 deletions.
33 changes: 26 additions & 7 deletions plugins/linux-pipewire/pipewire.c
Original file line number Diff line number Diff line change
Expand Up @@ -791,11 +791,10 @@ static void process_video_sync(obs_pipewire_stream *obs_pw_stream)
g_clear_pointer(&obs_pw_stream->texture, gs_texture_destroy);

use_modifiers = obs_pw_stream->format.info.raw.modifier != DRM_FORMAT_MOD_INVALID;
obs_pw_stream->texture = gs_texture_create_from_dmabuf(obs_pw_stream->format.info.raw.size.width,
obs_pw_stream->format.info.raw.size.height,
obs_pw_video_format.drm_format, GS_BGRX, planes,
fds, strides, offsets,
use_modifiers ? modifiers : NULL);
obs_pw_stream->texture = gs_texture_create_from_dmabuf(
obs_pw_stream->format.info.raw.size.width, obs_pw_stream->format.info.raw.size.height,
obs_pw_video_format.drm_format, obs_pw_video_format.gs_format, planes, fds, strides, offsets,
use_modifiers ? modifiers : NULL);

if (obs_pw_stream->texture == NULL) {
remove_modifier_from_format(obs_pw_stream, obs_pw_stream->format.info.raw.format,
Expand Down Expand Up @@ -1310,8 +1309,20 @@ void obs_pipewire_stream_video_render(obs_pipewire_stream *obs_pw_stream, gs_eff
gs_sync_destroy(acquire_sync);
}

effect = obs_get_base_effect(OBS_EFFECT_OPAQUE);
gs_technique_t *tech = gs_effect_get_technique(effect, "DrawSrgbDecompress");
gs_technique_begin(tech);
gs_technique_begin_pass(tech, 0);

const bool linear_srgb = gs_get_linear_srgb();
const bool previous = gs_framebuffer_srgb_enabled();
gs_enable_framebuffer_srgb(linear_srgb);

image = gs_effect_get_param_by_name(effect, "image");
gs_effect_set_texture(image, obs_pw_stream->texture);
if (linear_srgb)
gs_effect_set_texture_srgb(image, obs_pw_stream->texture);
else
gs_effect_set_texture(image, obs_pw_stream->texture);

rotated = push_rotation(obs_pw_stream);

Expand Down Expand Up @@ -1345,14 +1356,22 @@ void obs_pipewire_stream_video_render(obs_pipewire_stream *obs_pw_stream, gs_eff
gs_matrix_push();
gs_matrix_translate3f(cursor_x, cursor_y, 0.0f);

gs_effect_set_texture(image, obs_pw_stream->cursor.texture);
if (linear_srgb)
gs_effect_set_texture_srgb(image, obs_pw_stream->cursor.texture);
else
gs_effect_set_texture(image, obs_pw_stream->cursor.texture);
gs_draw_sprite(obs_pw_stream->texture, 0, obs_pw_stream->cursor.width, obs_pw_stream->cursor.height);

gs_matrix_pop();
}

gs_blend_state_pop();

gs_enable_framebuffer_srgb(previous);

gs_technique_end_pass(tech);
gs_technique_end(tech);

if (obs_pw_stream->sync.set) {
gs_sync_t *release_sync = gs_sync_create();
gs_sync_export_syncobj_timeline_point(release_sync, obs_pw_stream->sync.release_syncobj_fd,
Expand Down
2 changes: 1 addition & 1 deletion plugins/linux-pipewire/screencast-portal.c
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,7 @@ void screencast_portal_load(void)
const struct obs_source_info screencast_portal_capture_info = {
.id = "pipewire-screen-capture-source",
.type = OBS_SOURCE_TYPE_INPUT,
.output_flags = OBS_SOURCE_VIDEO,
.output_flags = OBS_SOURCE_VIDEO | OBS_SOURCE_SRGB,
.get_name = screencast_portal_desktop_capture_get_name,
.create = screencast_portal_capture_create,
.destroy = screencast_portal_capture_destroy,
Expand Down

0 comments on commit 7b21524

Please # to comment.