pyproject.toml, pre-commit, ruff, uv and typing issues, fixes #1119

[Dronakurl]

It looks big, but there is a lot of typing stuff, unneeded imports, etc, that can easily be seen doesn't change anything.
I added comments at the files that have noteworthy changes like bugs found from type checking.

Best way to start reading is pyproject.toml. Here you can see that ruff is used and the dependencies are defined.

The exisiting ci.yml pretended to run on different OS types, but actually did only run 3 times on ubuntu.
In this first step, I did not try to fix this.

Often I found syntax like x: int = None. I replaced it with x: Optional[int] = None so the type checker in my IDE (I used pyright) found cases where the code did not handle the None case. I fixed some of the issues around that.

What still confuses me in base.py is this: Is _object_prediction_list_per_image a list or a list of lists.
I figured that it could be both, so I defined a type for that.

With uv pre-commit install, you now have ruff pre-commits, that will do the equivalent of isort, black and flake.

Please tell me what you think

[Dronakurl]

The "build" workflow went through, you can have a look.
Open tasks for me:

• Why does huggingface get different inference results?
• package_testing workflow (maybe integrate into one workflow with different triggers)
• deepsparse does not work for V3.8-3.9 yet with my version
• pypi publish with uv (first to test-pypi)

optional

• improve the readme for contributions
• improve the explanations for list or list of lists in base.py
• type checking continued

[fcakyon]

Thanks for the great PR @Dronakurl !

Since there is 9000+ lines of changes (not only styling but critical code changes as well), GIthub Review UI is crashing 😅 and it might take weeks for me to review it.

It would be faster if you could separate this large PR (dependency change, workflow changes, project structure change, typo fixes, code logic changes) into smaller single purpose PRs.

For instance if I know the changes in a PR are only styling updates, I can review those lines faster but with current form, I have to go over each line to see if its a logical update or styling update.

It's up to you, I can review both ways, please let me know which way you want to move forward (split this PR into smaller PRs or keep it this way).

[Dronakurl]

Hi, thanks that you take a look! I am not yet finished with the pr, so it cannot be merged yet, see the todos. It might even take a week or so before I get to solve those remaining stuff. I will try to break it down where possible. There is a lot of typing stuff that can be separated.

[Dronakurl]

It’s not hard coded, it is a default, because the code was relying on a default value for the device. Or was what you describe a feature before and I accidentally broke it?

[fcakyon]

Because looking at the function, it reverts to cpu anyway. fatih akyon

Then you found an existing bug 😅

[fcakyon]

Of course, and they are still there! I am using pytest and the dependencies for ci are defined in pyproject.toml fatih akyon

Dependencies are OK, but pytest tests are not running. Only the CLI tests are running 🤔 https://github.com/obss/sahi/actions/runs/13220591930/job/36915618246?pr=1120

[Dronakurl]

I think, the PR is now ready for a final review.
I edited according to your comments on the draft and fixed the CI.
"package_testing" and "publish" workflows work on uv now, too (package_testing is included in ci.yml)

[fcakyon]

@Dronakurl, thanks a lot for all the work you put in!

Please add your profile/name to the contributor's list in the readme between Kadir Nar and Burak Maden 🤗