Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

added compatibility with stdlib.Seq for BatSeq #1005

Merged
merged 2 commits into from
Jan 19, 2021
Merged

added compatibility with stdlib.Seq for BatSeq #1005

merged 2 commits into from
Jan 19, 2021

Conversation

jabot2
Copy link
Contributor

@jabot2 jabot2 commented Jan 18, 2021

No description provided.

@jabot2
Copy link
Contributor Author

jabot2 commented Jan 18, 2021

Stdlib has a Seq module, which is almost compatible with BatSeq.
This PR adds the missing methods (with testcases), adds Legacy.Seq and adds Seq to the automatic compatibility check.

gasche
gasche approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, thanks in particular for enabling compatibility tests for Seq to catch future mismatches.

src/batSeq.mlv Show resolved Hide resolved
@UnixJunkie UnixJunkie merged commit 655d995 into ocaml-batteries-team:master Jan 19, 2021
@UnixJunkie
Copy link
Member

@jabot2 thanks for this contribution
@gasche thanks for the review

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@UnixJunkie UnixJunkie UnixJunkie left review comments

@gasche gasche gasche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jabot2 @UnixJunkie @gasche