Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dune preliminary: move toplevel-specific logic to its own toplevel/ directory #1017

Merged

Conversation

gasche
Copy link
Member

@gasche gasche commented Feb 3, 2021

Currently batteriesHelp.ml is in src/ but:

  • it is not included in batteries.cma
  • it cannot be compiled in native mode (it depends on Toploop which only has a bytecode version)

Both those properties confuse Dune, so it is simpler to move the toplevel-specific logic to a separate directory.

@gasche gasche force-pushed the dune-preliminary-toplevel branch from b1eb5b6 to b60d066 Compare February 5, 2021 16:09
@UnixJunkie UnixJunkie merged commit dd2b87d into ocaml-batteries-team:master Feb 8, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants