Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

add new Either module if OCaml >= 4.12 #1027

Merged
merged 5 commits into from
Feb 19, 2021
Merged

add new Either module if OCaml >= 4.12 #1027

merged 5 commits into from
Feb 19, 2021

Conversation

UnixJunkie
Copy link
Member

No description provided.

@UnixJunkie
Copy link
Member Author

Maybe, we should copy-paste the .ml file from the stdlib directly, and not make this new module conditional on the ocaml version.

@UnixJunkie
Copy link
Member Author

@gasche what do you think?

@gasche
Copy link
Member

gasche commented Feb 19, 2021

Indeed, you should not use a V>=4.12 conditional for this module, as it works with older OCaml versions. (Same for List.partition_map.)

@UnixJunkie
Copy link
Member Author

ok, I'll change that.

@UnixJunkie UnixJunkie merged commit f6f11fa into ocaml-batteries-team:master Feb 19, 2021
@UnixJunkie UnixJunkie deleted the new_either_module branch February 19, 2021 06:10
@UnixJunkie
Copy link
Member Author

Shouldn't we have added a constraint to specify that Eiter.t = BatEither.t, somehow?
For ocaml >= 4.12.

@UnixJunkie
Copy link
Member Author

I'll send a PR, we have the same constrain in BatSeq.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnixJunkie @gasche