Remove Flambda_arity.With_subkinds #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
requested review from
lukemaurer,
lthls,
chambart,
Gbury and
poechsel
as code owners
mshinwell
force-pushed
the
flambda2-remove-arity-with-subkinds
branch
from
b033c74 to
b561f58
Compare
lukemaurer
reviewed
Mar 21, 2023
This was
linked to
issues
Mar 23, 2023
mshinwell
force-pushed
the
flambda2-remove-arity-with-subkinds
branch
from
b561f58 to
8c51e68
Compare
Ekdohibs
approved these changes
Mar 30, 2023
mshinwell
force-pushed
the
flambda2-remove-arity-with-subkinds
branch
from
89459d2 to
7cd4ff8
Compare
Use exact comparison on subkinds for Compare Harmonise code with PR1250 unknown_types_from_arity equal_ignoring_subkind etc Use equal_ignoring_subkind + compilation fix
mshinwell
force-pushed
the
flambda2-remove-arity-with-subkinds
branch
from
3699321 to
dd46420
Compare
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, it seemed like this could be removed - and indeed its removal would make the forthcoming unarization work more straightforward. Actually removing it was unproblematic; arities now always have subkind info. Some unused functions have also been removed, so the interface to
Flambda_arityis now much smaller.