Refactor primitive handling in Lambda_to_flambda #1382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ekdohibs
reviewed
May 19, 2023
| let close_raise acc env ~raise_kind ~arg loc exn_continuation = | ||
| let acc, exn_cont = close_exn_continuation acc env exn_continuation in | ||
| let exn_handler = Exn_continuation.exn_handler exn_cont in | ||
| let acc, arg = find_simple acc env arg in |
There was a problem hiding this comment.
Since we already do let acc, args = find_simples acc env args in close_primitive, I think this might duplicate the definition of the constant corresponding to the argument if it is one.
| in | ||
| let raise_kind = Some (Trap_action.Raise_kind.from_lambda raise_kind) in | ||
| let trap_action = Trap_action.Pop { exn_handler; raise_kind } in | ||
| let dbg = Debuginfo.from_location loc in |
There was a problem hiding this comment.
Is there any reason to do that rather than give dbg as an argument (which is already known in one of the use sites) ?
| @@ -1430,9 +1430,12 @@ let primitive_result_layout (p : primitive) = | |||
| | Paddfloat _ | Psubfloat _ | Pmulfloat _ | Pdivfloat _ | |||
| | Pbox_float _ -> layout_float | |||
| | Punbox_float -> Punboxed_float | |||
| | Pccall _p -> | |||
| (* CR ncourant: use native_repr *) | |||
| | Pccall { prim_native_repr_res = _, Untagged_int; _} ->layout_int | |||
There was a problem hiding this comment.
Suggested change
| | Pccall { prim_native_repr_res = _, Untagged_int; _} ->layout_int | |
| | Pccall { prim_native_repr_res = _, Untagged_int; _} -> layout_int |
| @@ -1430,9 +1430,12 @@ let primitive_result_layout (p : primitive) = | |||
| | Paddfloat _ | Psubfloat _ | Pmulfloat _ | Pdivfloat _ | |||
| | Pbox_float _ -> layout_float | |||
| | Punbox_float -> Punboxed_float | |||
| | Pccall _p -> | |||
There was a problem hiding this comment.
Maybe we should add a case Pccall _ when not !Clflags.native_code -> layout_any_value ?
|
This is now in #1465 and the comments have been addressed there. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove the
primitive_result_kindfunction together with some duplicate code (callingtransform_primitive).