Use effects and coeffects of Cextcall in selectgen #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretay-js
force-pushed
the
use_effects_in_selection
branch
from
1c1466d to
fca9958
Compare
mshinwell
requested changes
Apr 28, 2021
gretay-js
force-pushed
the
use_effects_in_selection
branch
from
fca9958 to
297c158
Compare
gretay-js
requested review from
poechsel,
stedolan and
xclerc
as code owners
gretay-js
force-pushed
the
use_effects_in_selection
branch
from
43ade2a to
b036db9
Compare
xclerc
approved these changes
Sep 17, 2021
Currently restricted to primitives with [builtin=true]. Add Effect_and_coeffect.effect_and_coeffect for convenience
Use effects and coeffects in Selectgen for all Cextcall and not only for builtins.
gretay-js
force-pushed
the
use_effects_in_selection
branch
from
1bcf349 to
5633c16
Compare
xclerc
reviewed
Sep 17, 2021
mshinwell
approved these changes
Sep 29, 2021
mshinwell
pushed a commit
that referenced
this pull request
Oct 29, 2021
lpw25
added a commit
to lpw25/flambda-backend
that referenced
this pull request
Jul 4, 2022
0b0aefb Turn some partial application warnings into hints (#11338) (ocaml-flambda#30) 2caa9ee Add [@tail] and [@nontail] annotations on applications to control tailcalls (ocaml-flambda#31) 9fb218a Update `promote` target to use the `one` machinery (ocaml-flambda#28) b5ea912 Make empty types immediate bc08236 Add failing test of an empty type being immediate f2d439f Propagate escaping_context to Env locks to hint about errors (ocaml-flambda#25) 35569e1 Allow warning 68 to be controlled by attributes (ocaml-flambda#16) 28a6243 Allow type_argument to weaken return modes of expected function types (ocaml-flambda#24) cdc728f Fix 'make alldepend' in otherlibs/dynlink 7807d18 make alldepend 2d6af2f Merge flambda-backend changes git-subtree-dir: ocaml git-subtree-split: 0b0aefb
lpw25
added a commit
that referenced
this pull request
Jul 4, 2022
0b0aefb Turn some partial application warnings into hints (#11338) (#30) 2caa9ee Add [@tail] and [@nontail] annotations on applications to control tailcalls (#31) 9fb218a Update `promote` target to use the `one` machinery (#28) b5ea912 Make empty types immediate bc08236 Add failing test of an empty type being immediate f2d439f Propagate escaping_context to Env locks to hint about errors (#25) 35569e1 Allow warning 68 to be controlled by attributes (#16) 28a6243 Allow type_argument to weaken return modes of expected function types (#24) cdc728f Fix 'make alldepend' in otherlibs/dynlink 7807d18 make alldepend 2d6af2f Merge flambda-backend changes git-subtree-dir: ocaml git-subtree-split: 0b0aefb
lpw25
added a commit
that referenced
this pull request
Jul 4, 2022
0b0aefb Turn some partial application warnings into hints (#11338) (#30) 2caa9ee Add [@tail] and [@nontail] annotations on applications to control tailcalls (#31) 9fb218a Update `promote` target to use the `one` machinery (#28) b5ea912 Make empty types immediate bc08236 Add failing test of an empty type being immediate f2d439f Propagate escaping_context to Env locks to hint about errors (#25) 35569e1 Allow warning 68 to be controlled by attributes (#16) 28a6243 Allow type_argument to weaken return modes of expected function types (#24) cdc728f Fix 'make alldepend' in otherlibs/dynlink 7807d18 make alldepend git-subtree-dir: ocaml git-subtree-split: 0b0aefb
Gbury
pushed a commit
to Gbury/flambda-backend
that referenced
this pull request
Sep 14, 2022
lthls
added a commit
to lthls/flambda-backend
that referenced
this pull request
Sep 21, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #12, only the new last commit is new.
Currently restricted to builtin=true.