Loosen ownership of build files #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favor of this change. Or, if there are particular requirements @mshinwell and @xclerc know to check for in these files, what are they? Then others can also review. |
|
Yeah I think this is ok. |
mshinwell
approved these changes
Aug 30, 2023
Ekdohibs
pushed a commit
to Ekdohibs/flambda-backend
that referenced
this pull request
Aug 31, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having all changes to the
dune(etc.) files go through @mshinwell and @xclerc is very restrictive, and doesn't seem necessary. This PR drops that requirement, and leaves them owned by whoever owns the directory they reside in.This PR was inspired by this requirement delaying #1777.