Variant unboxing for parameters and returns #2328
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for variant unboxing on top of #1271.
I don't think we should merge it, as currently the code doesn't simplify away as well as we want to (even with Simplify). We will likely need some match-in-match support, and maybe some better support for poison-like values.
Also, we should probably restrict it to a subset of variant types for which it is reasonable.
But it should still work at preventing allocations:
Here,
g
will not allocate anything, but the unboxed version off
will do three switches instead of one. One is there because this PR always adds a switch onis_int
, which forresult
should always returnfalse
, and the two other ones are equivalent but cannot be simplified yet.