Only run memset when stack checks are enabled
#3553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stedolan
requested changes
Feb 10, 2025
stedolan
approved these changes
Feb 10, 2025
Dreian
pushed a commit
to Dreian/flambda-backend
that referenced
this pull request
Feb 19, 2025
Co-authored-by: Diana Kalinichenko <dkalinichenko@janestreet.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stack checks are disabled,
memsettries to access the guarded page of the stack, causing a segfault.This issue was introduced in #3384 and only shows ups when running effects with debug runtime.