OCaml 5: Backport flambda-backend#1960 #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* generalize hint to all unboxed types * add regression test * revert previous change * extra logic in Ptyp_class * better error wording
ncik-roberts
force-pushed
the
pull-flambda-backend-patches-2023-10-30-with-1960
branch
from
3a7f2f9 to
d23b27c
Compare
alanechang
approved these changes
Oct 31, 2023
mshinwell
added a commit
that referenced
this pull request
Jul 1, 2024
commit 62df46a Author: Nick Roberts <nroberts@janestreet.com> Date: Tue Oct 31 11:42:25 2023 -0400 OCaml 5: Backport flambda-backend#1960 (#268) * flambda-backend: Error message: add hint for unboxed types (#1960) * generalize hint to all unboxed types * add regression test * revert previous change * extra logic in Ptyp_class * better error wording * Fix backport of ocaml-flambda#1960 * Remove mention of now-deprecated t# syntax for poly variant type --------- Co-authored-by: alanechang <143514551+alanechang@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports ocaml-flambda/flambda-backend#1960 to ocaml-jst.
The first commit is a merge commit created with
jane/pull-backend-patches. I commit the output directly, with conflicts.The next two commits are changes on top of that. They merit more review scrutiny. Notes:
#tsyntax for polymorphic variant types, as this was removed in OCaml 5.Review suggestion: @alanechang