Add value_kind for blocks to propagate types from the lambda #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gbury
reviewed
Mar 31, 2021
|
Not exactly sure about upstreaming, but it would be useful to split this PR in two, one for the upstream and one for the Flambda 2 parts. |
mshinwell
requested changes
Apr 8, 2021
lpw25
requested changes
Apr 12, 2021
|
@lpw25 Please could you review this again |
chambart
force-pushed
the
more_value_kinds_flambda
branch
2 times, most recently
from
a256c71 to
9cb0ed8
Compare
|
I ended up adding the dead let handling specifically in expr_builder because it uses non-optimising let introduction functions. |
chambart
force-pushed
the
more_value_kinds_flambda
branch
from
9cb0ed8 to
a8826e4
Compare
mshinwell
approved these changes
Jul 6, 2021
mshinwell
force-pushed
the
more_value_kinds_flambda
branch
from
2431b3c to
d1763b5
Compare
|
I've made a few changes which will hopefully fix the CI, then will merge. |
This adds a code dependency between Typeopt and Lambda, which require some changes in the link order.
mshinwell
force-pushed
the
more_value_kinds_flambda
branch
from
b4e3ffc to
bf328a6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to unbox blocks arguments of recursive continuations.
Variants are not handled.
Should the non flambda part be pushed upstream, and when ?