Skip to content

Add (failing) {In,Out}_channel linearization tests #13

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

OlivierNicole
Copy link
Contributor

Note: this depends on #5, which is why I open it as a draft PR.

This adds linearizability testing for a few functions of the new Stdlib modules In_channel and Out_channel. As of now these functions are not thread-safe, so the tests fails, sometimes with segfaults (due to concurrent close and output functions in Out_channel).

Left to do:

  • Update dune file appropriately once the fate of Put Lin and STM libraries in a standalone package #5 is settled.
  • Determine how this (currently failing) can be integrated properly into the test suite.
  • Maybe enrich the test to cover more functions once their precise contract is decided by the compiler team (fix, or not fix and document, etc.)

@OlivierNicole
Copy link
Contributor Author

Closing as this is now superseeded by #270.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant