Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pkg: fix bug where multiple conflicts causes conlficts to be ignored #11492

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

gridbugs
Copy link
Collaborator

Conflicts were being combined as a conjunction bet they should have been combined with a disjunction.

Fixes #11265

Conflicts were being combined as a conjunction bet they should have been
combined with a disjunction.

Fixes ocaml#11265

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
Copy link
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great fix, looks very good! I like that it also fixes the behavior for depexts for which the same is true.

@rgrinberg rgrinberg merged commit fad056f into ocaml:main Feb 22, 2025
25 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package conflicts are ignored when dune-projects contains multiple conflicts
3 participants