Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Failure during include #587

Closed
jonludlam opened this issue Feb 11, 2021 · 1 comment
Closed

Failure during include #587

jonludlam opened this issue Feb 11, 2021 · 1 comment
Assignees
Milestone

Comments

@jonludlam
Copy link
Member

Repro (due to @lukemaurer)

a_intf.ml

module type S = sig
  module Foo : sig end
end

b_intf.ml

module Bar = struct end

module type S = sig
  include A_intf.S
  module Foo : sig end
end

module type B = sig
  module type S = S

  include S
end

b.mli

include B_intf.B

c.mli

include B.S

Causes a failure in Subst

@jonludlam jonludlam added this to the 2.0.0 milestone Feb 11, 2021
@jonludlam jonludlam self-assigned this Feb 12, 2021
jonludlam added a commit to jonludlam/odoc that referenced this issue Feb 25, 2021
Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam added a commit to jonludlam/odoc that referenced this issue Feb 25, 2021
Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam added a commit to jonludlam/odoc that referenced this issue Feb 25, 2021
Signed-off-by: Jon Ludlam <jon@recoil.org>
jonludlam added a commit that referenced this issue Feb 26, 2021
Signed-off-by: Jon Ludlam <jon@recoil.org>
@jonludlam
Copy link
Member Author

Fixed in #603

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant