Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[new release] alcotest-lwt, alcotest, alcotest-async and alcotest-mirage (1.2.1) #16818

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

craigfe
Copy link
Contributor

@craigfe craigfe commented Jul 15, 2020

CHANGES:

…age (1.2.1)

CHANGES:

- Surround pretty-printed diffs with quotes to make trailing whitespace more
  obvious. (mirage/alcotest#261, @craigfe)

- Allow `.` characters to appear unescaped in symlinks and test directories.
  (mirage/alcotest#259, @craigfe)
@camelus
Copy link
Contributor

camelus commented Jul 15, 2020

Commit: 78de960

@craigfe has posted 11 contributions.

☀️ All lint checks passed 78de960
  • These packages passed lint tests: alcotest-async.1.2.1, alcotest-lwt.1.2.1, alcotest-mirage.1.2.1, alcotest.1.2.1, current.0.2, current.0.3

☀️ Installability check (+4)
  • new installable packages (4): alcotest.1.2.1 alcotest-async.1.2.1 alcotest-lwt.1.2.1 alcotest-mirage.1.2.1

@mseri
Copy link
Member

mseri commented Jul 15, 2020

I think current.0.2 and 0.3 need an upper bound on alcotest, I am writing it here to remember to do it. The other failures seem unrelated

@craigfe
Copy link
Contributor Author

craigfe commented Jul 16, 2020

Having looked into it, the upper bounds in OCurrent are needed because it's using (implicit_transitive_deps false), and those packages need a new transitive dependency with Alcotest 1.2.

I've added upper bounds accordingly. OCurrent has already migrated to Alcotest 1.2 upstream: ocurrent/ocurrent#212. (thanks @talex5)

@mseri
Copy link
Member

mseri commented Jul 16, 2020

Thank you very much! I was planning to do it on a separate PR, you simplified my life 🙇

@mseri mseri merged commit ecbcb68 into ocaml:master Jul 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants