[new release] digestif (1.0.0) #17565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: - **breaking changes** Upgrade the library with MirageOS 3.9 (new layout of artifacts) Add tests about compilation of unikernels (execution and link) (mirage/digestif#105, @dinosaure, @hannesm) - Fix `esy` installation (mirage/digestif#104, @dinosaure) - **breaking changes** Better GADT (mirage/digestif#103, @dinosaure) As far as I can tell, nobody really use this part of `digestif`. The idea is to provide a GADT which contains the type of the hash. From third-part libraries point-of-view, it's better to _pattern-match_ with such information instead to use a polymorphic variant (as before). - **breaking changes** key used for HMAC is a constant `string` (mirage/digestif#101, @dinosaure, @hannesm) The key should not follow the same type as the digest value (`string`, `bytes`, `bigstring`). This update restricts the user to user only constant key (as a `string`).
|
Commit: 34c84b1 A pull request by opam-seasoned @dinosaure. ☀️ All lint checks passed 34c84b1
☀️ Installability check (+1)
|
|
all versions of Can you add an upper bound? |
|
Yes, it's expected 👍, I will add constraints on Git. |
dinosaure
force-pushed
the
release-digestif-1.0.0
branch
from
5493e3b to
3bcd865
Compare
mseri
reviewed
Nov 5, 2020
dinosaure
force-pushed
the
release-digestif-1.0.0
branch
from
3bcd865 to
bfa9742
Compare
|
The timeouts seems to be the more or less the same as with the other version (in particular no timeout on recent compilers), I think this is good to merge |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hashes implementations (SHA*, RIPEMD160, BLAKE2* and MD5)
CHANGES:
Add tests about compilation of unikernels (execution and link)
(New layout about freestanding & xen artifacts mirage/digestif#105, @dinosaure, @hannesm)
esyinstallation (Fix esy installation mirage/digestif#104, @dinosaure)As far as I can tell, nobody really use this part of
digestif.The idea is to provide a GADT which contains the type of the hash.
From third-part libraries point-of-view, it's better to pattern-match with
such information instead to use a polymorphic variant (as before).
string(Hmac string mirage/digestif#101, @dinosaure, @hannesm)The key should not follow the same type as the digest value (
string,bytes,bigstring).This update restricts the user to user only constant key (as a
string).