test gha: add in hygiene job to check default cli version on major bu…

…mp, on master push

.github/scripts/hygiene.sh

@@ -143,4 +143,21 @@ fi
 cd ..
 (set +x ; echo -en "::endgroup::check src_ext patches\r") 2>/dev/null
 
+###
+# Default cli version check
+###
+
+if [ "$GITHUB_EVENT_NAME" = "push" ] && [ "${GITHUB_REF##*/}" = "master" ]; then
+  (set +x ; echo -en "::group::check default cli\r") 2>/dev/null
+  CURRENT_MAJOR="`sed -n "s/^AC_INIT(opam,\([0-9]\+\)[^0-9]*.*)$/\1/p" configure.ac`"
+  DEFAULT_CLI_MAJOR="`sed -n "/let *default *=/s/.*(\([0-9]*\)[^0-9]*.*/\1/p" src/client/opamCLIVersion.ml`"
+  if [ $CURRENT_MAJOR -eq $DEFAULT_CLI_MAJOR ]; then
+    echo "Major viersion is default cli one: $CURRENT_MAJOR"
+  else
+    echo -e "[\e[31mERROR\e[0m] Major version $CURRENT_MAJOR and default cli version $DEFAULT_CLI_MAJOR mismatches"
+  (set +x ; echo -en "::endgroup::check default cli\r") 2>/dev/null
+    ERROR=1
+  fi
+fi
+
 exit $ERROR

src/client/opamCLIVersion.ml

@@ -27,6 +27,9 @@ let of_string s =
   | _ -> failwith "OpamVersion.CLI.of_string"
 
 let current = of_string @@ OpamVersion.(to_string current_nopatch)
+
+(* This line is checked on CI to ensure that default cli version
+   matches release opam version *)
 let default = (2,0)
 
 let of_string_opt s = try Some (of_string s) with Failure _ -> None

src/client/opamCLIVersion.mli

@@ -15,7 +15,8 @@ include OpamStd.ABSTRACT
 (** The current version of the CLI (major and minor of OpamVersion.current *)
 val current : t
 
-(* Default CLI version, currently 2.0 *)
+(* Default CLI version, currently 2.0.
+   This value is checked in CI. *)
 val default : t
 
 (** Tests whether a valid CLI version is supported by the client library *)