-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Introducing default cli #4575
Merged
Merged
Introducing default cli #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
reviewed
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks! The only changes are the misspelling of previously_str
and the deprecation warning can be re-worded. Semantically it's doing exactly what's needed, and I very much like OpamCLIVersion.default
. Perhaps it could be automatically the major version of opam?
dcac971
to
71cfb30
Compare
rjbou
commented
Mar 10, 2021
dra27
reviewed
Mar 10, 2021
* Add a default cli version, here 2.0 * When no cli is specified (cli option or env), deprecated options do not behave as deprecated
cli: reword default cli warning Co-authored-by: David Allsopp <david.allsopp@metastack.com>
…mp, on master push
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some deprecated options need to still be accepted (cf. #4503). The default cli is here to allow them when used with no specified cli (not from environment or from option
--cli
). Opam prints then a removal warning notice.The default version is set to 2.0, it will be upgraded at each major release.
Default cli options are ftm
opam config
deprecated commands.Example with
config var
: