OPAMSWITCH and OPAMROOT reverts
#5743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI issue @@ -96,11 +96,20 @@ opam sw show
### sh unset-opamswitch.sh opam
foo
OPAMSWITCH='bar'; export OPAMSWITCH;
-OPAMSWITCH=''; export OPAMSWITCH;
-bar
+unset-opamswitch.sh: line 13: $'\r': command not found
+unset-opamswitch.sh: line 13: $'\r': command not found
+unset-opamswitch.sh: line 13: $'\r': command not found
+unset-opamswitch.sh: line 13: $'\r': command not found
+unset-opamswitch.sh: line 13: $'\r': command not found
+foowill be resolved by #5715 |
rjbou
added
the
PR: QUEUED
|
Other solution could be to not store |
|
Updated! |
dra27
reviewed
Jan 8, 2024
kit-ty-kate
force-pushed
the
switch-revert
branch
2 times, most recently
from
1c98f6f to
847704b
Compare
… not be reverted They are set by '--set-switch' and '--set-root' with the idea to have them defined for the session
kit-ty-kate
force-pushed
the
switch-revert
branch
from
847704b to
7f5f055
Compare
kit-ty-kate
approved these changes
Jan 11, 2024
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store oldOPAMSWITCHin last env file, in order to revert it properlyDon't store
OPAMSWITCH&OPAMROOTin the last environment file, like that they are not reverted. They are set with--set-switchand--set-root, they are meant to remain in the shell environment.fixes #5696
queued on #5715 for windows ci