Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tweak incorrect case in --cygwin-extra-packages #5964

Merged
merged 1 commit into from
May 20, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented May 18, 2024

An incorrectly translated case in #5930 means opam init with no arguments at the moment unconditionally installs an internal Cygwin! Easy to review based on the diff of the original commit in 8bc1214 - the | `none, None -> None deleted case at L419 has no equivalent in the new code (indeed, no case yields None).

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 391333d into ocaml:master May 20, 2024
29 checks passed
@dra27 dra27 deleted the tweak-cygwin-packages branch May 25, 2024 19:48
@dra27 dra27 mentioned this pull request Jun 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants