Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch to move from caml.inria.fr to github.com #6032

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

mtelvers
Copy link
Contributor

This fix is necessary due to ocaml/ocaml#13237 and allow us to build base images ocurrent/docker-base-images#283 again.

I have tested this patch in the base image builder using this commit and successfully built a base image with opam 2.0, 2.1 and dev.

@mtelvers
Copy link
Contributor Author

# docker run --rm -it docker.io/ocurrent/opam-staging:ubuntu-24.04-opam-arm64
opam@70d084a3b203:~$ opam-2.0 --version
2.0.10
opam@70d084a3b203:~$ opam-2.1 --version
2.1.6
opam@70d084a3b203:~$ opam-2.2 --version
2.2.0~rc1~dev
opam@70d084a3b203:~$ opam-dev --version
2.2.0~rc1~dev

@shonfeder
Copy link
Contributor

LGTW, fwiw :)

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. It seems strange that we (opam) use caml.inria.fr when opam-repository's ocaml-base-compiler.4.14.2 uses GitHub already, so I think the consistency is good, regardless of the downtime on caml.inria.fr

@dra27 dra27 merged commit 62b041a into ocaml:master Jun 19, 2024
29 checks passed
@mtelvers mtelvers deleted the inria-patch branch June 19, 2024 21:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants