Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not pre-write the answer to questions with the default anwser #6376

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Jan 24, 2025

Supersedes #6290
This implements #6289 (review)

@kit-ty-kate kit-ty-kate added AREA: UI PR: QUEUED Pending pull request, waiting for other work to be merged or closed labels Jan 24, 2025
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Jan 24, 2025
@kit-ty-kate kit-ty-kate force-pushed the no-prewrite-yn-answers branch from 57cf486 to ac627d0 Compare January 24, 2025 23:29
@kit-ty-kate kit-ty-kate force-pushed the no-prewrite-yn-answers branch from ac627d0 to 125f74c Compare February 4, 2025 13:11
@kit-ty-kate kit-ty-kate removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Feb 4, 2025
@kit-ty-kate kit-ty-kate force-pushed the no-prewrite-yn-answers branch from 125f74c to 157c7cf Compare February 4, 2025 13:14
@kit-ty-kate kit-ty-kate requested a review from rjbou February 4, 2025 13:14
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the code itself, lgtm!
The commit should be split in 2 commits

@kit-ty-kate
Copy link
Member Author

The commit should be split in 2 commits

why? I don't think this is reasonable without introducing new bugs in between the two commits

@kit-ty-kate kit-ty-kate force-pushed the no-prewrite-yn-answers branch from 157c7cf to 6e89c8c Compare February 10, 2025 14:18
@kit-ty-kate
Copy link
Member Author

I don't think this is reasonable without introducing new bugs in between the two commits

sorry nevermind, i was thinking of something else. Done.

@kit-ty-kate kit-ty-kate merged commit 4aa865a into ocaml:master Feb 10, 2025
44 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants