Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set OPAMSOLVERTIMEOUT to 1000 to avoid a timeout #191

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Aug 2, 2021

Related issue: ocaml/opam#3447

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pick a bigger number, rather than making it unlimited!

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto changed the title Set OPAMSOLVERTIMEOUT to unlimited to avoid a timeout Set OPAMSOLVERTIMEOUT to 1000 to avoid a timeout Aug 6, 2021
@smorimoto
Copy link
Member Author

I changed from unlimited to 1000. It still feels a little big, but I think it's fine for now.

@smorimoto smorimoto added the enhancement New feature or request label Aug 6, 2021
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smorimoto smorimoto merged commit 36a0455 into master Aug 26, 2021
@smorimoto smorimoto deleted the timeout branch August 26, 2021 12:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants