fix(session):If function is custom, executing 'select function' in sql window should need database change permission #4123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijiacj
requested review from
LuckyPickleZZ,
LioRoger,
MarkPotato777,
guowl3 and
PeachThinking
as code owners
zijiacj
added
type-bug
zijiacj
changed the title
server/odc-service/src/main/java/com/oceanbase/odc/service/session/util/DBSchemaExtractor.java
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
Currently, executing the
select functionin sql windows is identified asselecttype. Only thequerypermission of the database is required. However, custom functions can change the state of the database, so they should be changed to requirechangepermission of database.This pr will judge the function contained in the sql statement. If it is a custom function,
queryandchangepermission are both required . If it is a system native function, onlyqueryis required.So the approach is this: If the function is a custom function, only need to add
SqlType.ALTERto the correspondingsetofSqlType, so that the subsequent resource verification logic can be reused.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: