Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(sql-execute): nls_format invalidation #4203

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

LuckyPickleZZ
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

The NlsFormatInterceptor failed to recognize statement like set variables='xxx'.
image

image

@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.4 milestone Feb 6, 2025
@LuckyPickleZZ LuckyPickleZZ self-assigned this Feb 6, 2025
@LuckyPickleZZ LuckyPickleZZ changed the base branch from dev/4.3.x to dev/4.3.3 February 8, 2025 03:47
@LuckyPickleZZ LuckyPickleZZ changed the base branch from dev/4.3.3 to dev/4.3.x February 13, 2025 03:09
@LuckyPickleZZ LuckyPickleZZ changed the base branch from dev/4.3.x to dev/4.3.3 February 13, 2025 06:42
@MarkPotato777 MarkPotato777 added the type-bug Something isn't working label Feb 13, 2025
Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LioRoger LioRoger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LioRoger LioRoger merged commit bdd4f6b into dev/4.3.3 Feb 13, 2025
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type-bug Something isn't working
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

3 participants