Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rebuild OHW22 toctree #246

Merged
merged 6 commits into from
May 24, 2023
Merged

Rebuild OHW22 toctree #246

merged 6 commits into from
May 24, 2023

Conversation

abkfenris
Copy link
Contributor

@abkfenris abkfenris commented May 24, 2023 •
edited
Loading

It looks like a page needs to be in an existing toctree, before Sphinx will build a toctree for it.

I've added it back to the primary toctree, but I've limited the number of entries that will display in the menu.

I've also gone and removed the duplicate search options from the menu while I was there.

Closes #245

@abkfenris
Rebuild OHW22 toctree
1870643 
It looks like a page needs to be in an existing toctree, before Sphinx will build a toctree for it.

I've added it back to the primary toctree, but I've limited the number of entries that will display in the menu.

I've also gone and removed the duplicate search options from the menu while I was there.

Closes oceanhackweek#245
@abkfenris abkfenris requested a review from emiliom May 24, 2023 16:48
@netlify
Copy link

netlify bot commented May 24, 2023 •
edited
Loading

✅ Deploy Preview for oceanhackweek-preview ready!

Name Link
🔨 Latest commit 22c930b
🔍 Latest deploy log https://app.netlify.com/sites/oceanhackweek-preview/deploys/646e46e88bf2430008543aad
😎 Deploy Preview https://deploy-preview-246--oceanhackweek-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@emiliom
Copy link
Member

emiliom commented May 24, 2023

It looks like a page needs to be in an existing toctree, before Sphinx will build a toctree for it.

I've added it back to the primary toctree, but I've limited the number of entries that will display in the menu.

So, OHW22 is now in the top bar. It sounds like you intended to have header_links_before_dropdown effectively clip it, right? Maybe set header_links_before_dropdown to 2?

I've also gone and removed the duplicate search options from the menu while I was there.

Thank you! That's been a bit annoying. But, at least on the netlify preview, the search box is now gone.

Thanks!

@abkfenris
Copy link
Contributor Author

I think netlify was ignoring the search and the limits as it was using an old version of the theme.

@abkfenris
Copy link
Contributor Author

And it was using an old version of Python.

@abkfenris
Copy link
Contributor Author

And it doesn't support 3.10. Grr.

@abkfenris
Copy link
Contributor Author

Ok, now @emiliom it should be working.

emiliom
emiliom approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@emiliom emiliom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great!! I like the "More" drop-down. Good to go.

@abkfenris abkfenris merged commit 1aed871 into oceanhackweek:source May 24, 2023
@abkfenris abkfenris mentioned this pull request May 24, 2023
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@emiliom emiliom emiliom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resurface menu in OHW22 pages
2 participants
@abkfenris @emiliom