Getting COOPS stations within region

[SorooshMani-NOAA]

In stormevents there's this assumption in one of the automated tests that if an empty geometry is passed to the coops_stations_within_region, the return data frame will be empty. Right now that test is broken because the logic in searvey is that:

searvey/searvey/coops.py

Lines 824 to 827 in d654ad6

	if region:
	return stations[stations.within(region)]
	else:
	return stations

@pmav99, @carolakaiser in your opinions, does it make sense to keep searvey as it is and just update the stormevents test or should I modify how coops_stations_within_region works in searvey?

What was the use-case for adding this code @carolakaiser? Do you have a case where if you pass empty geometry then you want to get all of the stations? Or are you passing None instead of empty geometry to get all the stations? If you're usecase is covered by passing None, then we can change this to if region is None: then both of our use-cases are covered.

What do you think?

[pmav99]

If region is None is the proper fix here. I.e. if the user did not specify a specific region, return the full dataset.

I would probably write it like this though:

if region is not None:
    stations = stations[stations.within(region)]

return stations

[SorooshMani-NOAA]

Thank you, I'll also wait for @carolakaiser before making this change, just to make sure I don't break her workflow either.

[carolakaiser]

if region is None sounds like a good approach. I think this would work well.