Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

coops: Differentiate between empty region and no region input #92

Merged

Conversation

SorooshMani-NOAA
Copy link
Contributor

Fixes #60

@SorooshMani-NOAA SorooshMani-NOAA requested a review from pmav99 July 5, 2023 15:29
@SorooshMani-NOAA
Copy link
Contributor Author

SorooshMani-NOAA commented Jul 5, 2023

@pmav99, from the ticket perspective the fix is done. The test errors here seem to be related to USGS server failure in SSL cert verification. Related to DOI-USGS/dataretrieval-python#100

@SorooshMani-NOAA
Copy link
Contributor Author

@pmav99 the USGS server issue is resolved. But the remaining tests fail due to the same IOC NA issue: #91

@pmav99
Copy link
Member

pmav99 commented Jul 10, 2023

@SorooshMani-NOAA I am on leave for a few days. If it is not too much trouble, please apply this patch: #91 (comment)

@SorooshMani-NOAA
Copy link
Contributor Author

@pmav99 sure, thanks

@SorooshMani-NOAA SorooshMani-NOAA linked an issue Jul 10, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #92 (a225974) into master (1309683) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   90.16%   90.17%           
=======================================
  Files          13       13           
  Lines        1007     1008    +1     
  Branches      148      148           
=======================================
+ Hits          908      909    +1     
  Misses         54       54           
  Partials       45       45           
Impacted Files Coverage Δ
searvey/coops.py 84.30% <100.00%> (ø)
searvey/stations.py 100.00% <100.00%> (ø)

@SorooshMani-NOAA SorooshMani-NOAA merged commit 78d2847 into oceanmodeling:master Jul 11, 2023
@SorooshMani-NOAA SorooshMani-NOAA deleted the enhance/coops_region branch July 11, 2023 13:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected data value raises an error for IOC Getting COOPS stations within region
2 participants