Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update predictSlot status on trueval submit #716

Merged

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Aug 22, 2023

Fixes #715

Changes proposed in this PR:

  • Update predictSlot status on trueval submit
  • Use Int for slot

@trizin trizin linked an issue Aug 22, 2023 that may be closed by this pull request
@trizin trizin changed the base branch from main to feature/predictoor August 22, 2023 10:25
@trizin trizin changed the title Update predictSlot status on trueval submit Update predictSlot status on trueval submit and use int for slot Aug 22, 2023
@trizin trizin changed the title Update predictSlot status on trueval submit and use int for slot Update predictSlot status on trueval submit Aug 22, 2023
@trizin trizin requested a review from trentmc August 22, 2023 16:27
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know js well so I don't feel well qualified to review.

Is there a way to put in some basic tests for this?

@trizin
Copy link
Contributor Author

trizin commented Aug 28, 2023

It's difficult to add tests for these changes without having the rest of the tests. We've been using this branch in barge for almost a week now, seems ok so far.

@alexcos20 alexcos20 merged commit 8a28991 into feature/predictoor Aug 29, 2023
@alexcos20 alexcos20 deleted the issue715-add-truevalsubmitted-into-predictslots branch August 29, 2023 12:40
alexcos20 added a commit that referenced this pull request Nov 21, 2023
* first cut, still WIP

* use specific contracts image

* fix missing abi

* more predictoor

* more predictoor

* done predictoor logic

* fix

* update

* merge #682

* update ready logic

* fixes

* lint

* increase timeout

* add oasis-saphire-testnet

* bump to contracts v2.0.0-next.2

* add loop for crappy rpc

* merge template

* fixes 1

* fixes

* fix predictor detection

* Use latest predictoor contracts (#708)

* Update tests.yml

* Update handlers

* Update schema

* Linter

* Update abi and fields

* use latest contracts

* use latest contracts

* expose agg preds in trueval

* fix abi path

* remove unused abis

* fix

---------

Co-authored-by: trizin <25263018+trizin@users.noreply.github.com>

* bump contracts

* Remove floatValue from predictoor trueval handler  (#714)

* Update predictSlot status on trueval submit (#716)

* Update status

* Fix

* Update contracts version

* Use number for predict slot

* Fixes

* Linter

* Fix

* Fix

* tostring

* Fix

* Fix

* Fix

* use contracts v2.0.0-next.11

* use latest graph-cli

* remove --debug flag

* Feature/add predictoor pause event (#723)

* bump contracts

* add pause for predictoorContract

* bump contracts to v2.0.0-13

* bum contracts & add sapphire mainnet

* fix lock

---------

Co-authored-by: trizin <25263018+trizin@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add truevalSubmitted into predictSlots
3 participants