-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update predictSlot status on trueval submit #716
Merged
alexcos20
merged 13 commits into
feature/predictoor
from
issue715-add-truevalsubmitted-into-predictslots
Aug 29, 2023
Merged
Update predictSlot status on trueval submit #716
alexcos20
merged 13 commits into
feature/predictoor
from
issue715-add-truevalsubmitted-into-predictslots
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentmc
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know js well so I don't feel well qualified to review.
Is there a way to put in some basic tests for this?
It's difficult to add tests for these changes without having the rest of the tests. We've been using this branch in barge for almost a week now, seems ok so far. |
alexcos20
approved these changes
Aug 29, 2023
alexcos20
added a commit
that referenced
this pull request
Nov 21, 2023
* first cut, still WIP * use specific contracts image * fix missing abi * more predictoor * more predictoor * done predictoor logic * fix * update * merge #682 * update ready logic * fixes * lint * increase timeout * add oasis-saphire-testnet * bump to contracts v2.0.0-next.2 * add loop for crappy rpc * merge template * fixes 1 * fixes * fix predictor detection * Use latest predictoor contracts (#708) * Update tests.yml * Update handlers * Update schema * Linter * Update abi and fields * use latest contracts * use latest contracts * expose agg preds in trueval * fix abi path * remove unused abis * fix --------- Co-authored-by: trizin <25263018+trizin@users.noreply.github.com> * bump contracts * Remove floatValue from predictoor trueval handler (#714) * Update predictSlot status on trueval submit (#716) * Update status * Fix * Update contracts version * Use number for predict slot * Fixes * Linter * Fix * Fix * tostring * Fix * Fix * Fix * use contracts v2.0.0-next.11 * use latest graph-cli * remove --debug flag * Feature/add predictoor pause event (#723) * bump contracts * add pause for predictoorContract * bump contracts to v2.0.0-13 * bum contracts & add sapphire mainnet * fix lock --------- Co-authored-by: trizin <25263018+trizin@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715
Changes proposed in this PR: