Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

use fqdn for ipp #734

Merged
merged 1 commit into from
Aug 23, 2019
Merged

use fqdn for ipp #734

merged 1 commit into from
Aug 23, 2019

Conversation

cg505
Copy link
Member

@cg505 cg505 commented Aug 22, 2019 •
edited
Loading

Without this, printing was failing with CUPS backend /usr/lib/cups/backend/ipps returned 4.

@jxlin123 Thoughts?

@cg505 cg505 requested a review from fydai August 22, 2019 23:37
@cg505 cg505 mentioned this pull request Aug 23, 2019
Closed
@jxlin123
Copy link
Contributor

@cg505 Interesting, I never thought this would pop up! Thanks for catching this issue...

To confirm, how did you get error code 5? So far I'm only seeing error code 4, and you've mentioned 4 as well in rebuild...

@jxlin123 jxlin123 mentioned this pull request Aug 23, 2019
Closed
3 tasks
@cg505
Copy link
Member Author

cg505 commented Aug 23, 2019

... I think that was just a typo. I updated OP

@cg505 cg505 merged commit 0c594c4 into master Aug 23, 2019
@cg505 cg505 deleted the fix-printing branch August 23, 2019 03:07
@jxlin123
Copy link
Contributor

jxlin123 commented Aug 23, 2019 •
edited
Loading

Cool, cool, thanks once again for the changes!

We may need to also restart CUPS on all the machines in order to make sure these changes apply, since the currently running instances of CUPS may still be using the old addresses.

MCer4294967296 pushed a commit to MCer4294967296/puppet that referenced this pull request Sep 24, 2019
@cg505 @MCer4294967296
use fqdn for ipp (ocf#734)
b5a934b
cg505 added a commit that referenced this pull request Oct 3, 2019
@cg505
revert all recent printing commits
a6176bd 
Revert "Partial revert of 27a120"

This reverts commit da8b927.

Revert "temporarily remove local PPDs because of multiple copy issues"

This reverts commit 4e92142.

Revert "Add NOPASSWD when giving root to individual users"

This reverts commit 7083e9e.

Revert "Add size checks to raster-filter"

This reverts commit 66ae9e4.

Revert "clear cups queues and re-enable printers on login"

This reverts commit b32b453.

Revert "add ppd files for local printer with page size and duplex info"

This reverts commit 684ac76.

Revert "Revert "Removing printhost check for Google Docs" (#740)"

This reverts commit 34f75e8.

Revert "use fqdn for ipp (#734)"

This reverts commit 0c594c4.

Revert "Tweaked raster-filter if statements"

This reverts commit 7741552.

Revert "Some tweaks to convert_failure"

This reverts commit 56bd453.

Revert "Improved raster-filter, convert_failure"

This reverts commit 4ae1e2e.

Revert "Make raster-filter email convert error message to root mailing list"

This reverts commit d103a38.

Revert "Remove libimage-exiftool-perl from packages.pp"

This reverts commit 1e8f81a.

Revert "Small change to raster-filter"

This reverts commit 0031c19.

Revert "Removing printhost check for Google Docs"

This reverts commit c055f88.

Revert "Further removing old PDF rasterization setup"

This reverts commit 1b5fcf6.

Revert "Changing browser settings to open PDFs in-browser"

This reverts commit 27a120c.

Revert "Remove PDF rasterization upon clicking on a PDF"

This reverts commit 8c36210.

Revert "Changing ImageMagick settings to give more memory"

This reverts commit 39d6970.

Revert "New CUPS settings, to have PDFs rasterized before printing"

This reverts commit cabb0ac.
@cg505 cg505 mentioned this pull request Oct 3, 2019
Merged
cg505 added a commit that referenced this pull request Oct 3, 2019
@cg505
revert all recent printing commits
0d342be 
Revert "Partial revert of 27a120"

This reverts commit da8b927.

Revert "temporarily remove local PPDs because of multiple copy issues"

This reverts commit 4e92142.

Revert "Add size checks to raster-filter"

This reverts commit 66ae9e4.

Revert "clear cups queues and re-enable printers on login"

This reverts commit b32b453.

Revert "add ppd files for local printer with page size and duplex info"

This reverts commit 684ac76.

Revert "Revert "Removing printhost check for Google Docs" (#740)"

This reverts commit 34f75e8.

Revert "use fqdn for ipp (#734)"

This reverts commit 0c594c4.

Revert "Tweaked raster-filter if statements"

This reverts commit 7741552.

Revert "Some tweaks to convert_failure"

This reverts commit 56bd453.

Revert "Improved raster-filter, convert_failure"

This reverts commit 4ae1e2e.

Revert "Make raster-filter email convert error message to root mailing list"

This reverts commit d103a38.

Revert "Remove libimage-exiftool-perl from packages.pp"

This reverts commit 1e8f81a.

Revert "Small change to raster-filter"

This reverts commit 0031c19.

Revert "Removing printhost check for Google Docs"

This reverts commit c055f88.

Revert "Further removing old PDF rasterization setup"

This reverts commit 1b5fcf6.

Revert "Changing browser settings to open PDFs in-browser"

This reverts commit 27a120c.

Revert "Remove PDF rasterization upon clicking on a PDF"

This reverts commit 8c36210.

Revert "Changing ImageMagick settings to give more memory"

This reverts commit 39d6970.

Revert "New CUPS settings, to have PDFs rasterized before printing"

This reverts commit cabb0ac.
cg505 added a commit that referenced this pull request Oct 3, 2019
@cg505
revert all recent printing commits
3413cbf 
Revert "Partial revert of 27a120"

This reverts commit da8b927.

Revert "temporarily remove local PPDs because of multiple copy issues"

This reverts commit 4e92142.

Revert "Add size checks to raster-filter"

This reverts commit 66ae9e4.

Revert "clear cups queues and re-enable printers on login"

This reverts commit b32b453.

Revert "add ppd files for local printer with page size and duplex info"

This reverts commit 684ac76.

Revert "Revert "Removing printhost check for Google Docs" (#740)"

This reverts commit 34f75e8.

Revert "use fqdn for ipp (#734)"

This reverts commit 0c594c4.

Revert "Tweaked raster-filter if statements"

This reverts commit 7741552.

Revert "Some tweaks to convert_failure"

This reverts commit 56bd453.

Revert "Improved raster-filter, convert_failure"

This reverts commit 4ae1e2e.

Revert "Make raster-filter email convert error message to root mailing list"

This reverts commit d103a38.

Revert "Remove libimage-exiftool-perl from packages.pp"

This reverts commit 1e8f81a.

Revert "Small change to raster-filter"

This reverts commit 0031c19.

Revert "Removing printhost check for Google Docs"

This reverts commit c055f88.

Revert "Further removing old PDF rasterization setup"

This reverts commit 1b5fcf6.

Revert "Changing browser settings to open PDFs in-browser"

This reverts commit 27a120c.

Revert "Remove PDF rasterization upon clicking on a PDF"

This reverts commit 8c36210.

Revert "Changing ImageMagick settings to give more memory"

This reverts commit 39d6970.

Revert "New CUPS settings, to have PDFs rasterized before printing"

This reverts commit cabb0ac.
ja5087 pushed a commit to ja5087/puppet that referenced this pull request Oct 19, 2019
@cg505 @ja5087
revert all recent printing commits
2ad7bcb 
Revert "Partial revert of 27a120"

This reverts commit da8b927.

Revert "temporarily remove local PPDs because of multiple copy issues"

This reverts commit 4e92142.

Revert "Add size checks to raster-filter"

This reverts commit 66ae9e4.

Revert "clear cups queues and re-enable printers on login"

This reverts commit b32b453.

Revert "add ppd files for local printer with page size and duplex info"

This reverts commit 684ac76.

Revert "Revert "Removing printhost check for Google Docs" (ocf#740)"

This reverts commit 34f75e8.

Revert "use fqdn for ipp (ocf#734)"

This reverts commit 0c594c4.

Revert "Tweaked raster-filter if statements"

This reverts commit 7741552.

Revert "Some tweaks to convert_failure"

This reverts commit 56bd453.

Revert "Improved raster-filter, convert_failure"

This reverts commit 4ae1e2e.

Revert "Make raster-filter email convert error message to root mailing list"

This reverts commit d103a38.

Revert "Remove libimage-exiftool-perl from packages.pp"

This reverts commit 1e8f81a.

Revert "Small change to raster-filter"

This reverts commit 0031c19.

Revert "Removing printhost check for Google Docs"

This reverts commit c055f88.

Revert "Further removing old PDF rasterization setup"

This reverts commit 1b5fcf6.

Revert "Changing browser settings to open PDFs in-browser"

This reverts commit 27a120c.

Revert "Remove PDF rasterization upon clicking on a PDF"

This reverts commit 8c36210.

Revert "Changing ImageMagick settings to give more memory"

This reverts commit 39d6970.

Revert "New CUPS settings, to have PDFs rasterized before printing"

This reverts commit cabb0ac.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cg505 @jxlin123 @emmatyping